Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvmBuilder and its dependencies #1 #82

Closed
wants to merge 1 commit into from

Conversation

x-senpai-x
Copy link

FIles Overview :
Common File Common.go
1)EvmBuilder.go: generic builder for creating EVM instances. creating a default builder, updating the database, and modifying the environment settings for the EVM.
2)Handler.go:
This file defines the Handler and EvmHandler types for managing Ethereum Virtual Machine (EVM) execution contexts in Go. It includes configuration structures (HandlerCfg), methods for initializing handlers for different Ethereum specifications (mainnet and optimism)
Build FLags used for optimism
to enable them add it in gopls through settings
"gopls": {
"buildFlags": ["optimism"]
}

3)Context.go : creating and managing the contexts necessary for executing EVM operations
4)EvmContext.go:managing the EVM context within a specified database environment
5)Precompiles.go: integrating and executing precompiles in an EVM environment

6)InnerEvmContext.go:manage the internal state of the EVM execution environment. L1 block info holds parameters related to layer 1 block information
7)Journal.go:managing the state of evm environment
8)Journal_Entry.go :tracking state changes (account changes and storage modifications)

Files contain some commented out functions And some functions with comment not in use No need to test them

@x-senpai-x
Copy link
Author

Marshal Unmarshal might need to be implemented again
I am not very confident about their implementation

b.RegisterFn(handler)
}
/*
func (s SpecId) IsEnabledIn(spec SpecId) bool {
Copy link
Contributor

@gerceboss gerceboss Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@x-senpai-x ,remove all these unnecessary comments from this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please do the suggested changes? And also mention the sequence of PRs for the evm.go

@gerceboss
Copy link
Contributor

@x-senpai-x , please donot add any undefined things in a PR , you can always add them in the next ones like the ones you made in a series, if the build and tests fail , then I can't make sure if the integrated code at the end will work.

@x-senpai-x
Copy link
Author

@gerceboss The issue is that in evm module most of the things are related to each other
So if I ensure that no undefined thing remains then I'll end up having all 27 files in the same pr

@x-senpai-x , please donot add any undefined things in a PR , you can always add them in the next ones like the ones you made in a series, if the build and tests fail , then I can't make sure if the integrated code at the end will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants